vrepl: CreateLookupVindex command with backfill#5692
Merged
sougou merged 10 commits intovitessio:masterfrom Jan 15, 2020
Merged
vrepl: CreateLookupVindex command with backfill#5692sougou merged 10 commits intovitessio:masterfrom
sougou merged 10 commits intovitessio:masterfrom
Conversation
deepthi
approved these changes
Jan 15, 2020
Collaborator
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
LGTM except for a couple of nits.
go/vt/vtctl/vtctl.go
Outdated
| "[-cell=<cell>] [-tablet_types=<tablet_types>] -workflow=<workflow> <source_keyspace> <target_keyspace> <table_specs>", | ||
| `Start a table(s) migration, table_specs is a list of tables or the tables section of the vschema for the target keyspace. Example: '{"t1":{"column_vindexes": [{""column": "id1", "name": "hash"}]}, "t2":{"column_vindexes": [{""column": "id2", "name": "hash"}]}}`}, | ||
| {"CreateLookupVindex", commandCreateLookupVindex, | ||
| "[-cell=<cell>] [-tablet_types=<tablet_types>] <keyspace> <json_spec>", |
Collaborator
There was a problem hiding this comment.
Can you explain tablet_types with more detail?
go/vt/vtctl/vtctl.go
Outdated
| return err | ||
| } | ||
| if subFlags.NArg() != 2 { | ||
| return fmt.Errorf("two arguments are required: keyspace and specs") |
Convenience function to automatically choose a good vindex for a type. Will be used for upcoming CreateLookupVindex functionality. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
sougou
force-pushed
the
ss-create-lookup
branch
from
b08a8b0 to
727f307
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This command comes very close to a DDL that can create a lookup vindex on an existing table that already has rows. It will:
If the table is the "owner", then the vreplication streams are created with "stop_after_copy" option. Otherwise, we assume that it's a "best effort" vindex where the lookup table is continuously populated by the vreplication stream.
The final step of this workflow will come in the next PR as
ExternalizeVindex, which would remove the "write_only" mode and/or delete the vreplication streams.